Drop Python 3.7 support #722
Conversation
yarikoptic
commented
Dec 8, 2023
•
yarikoptic
commented
- Might need Ran pre-commit on everything, black decided to adjust some formatting #721 merged first since resolves problem with deprecation warning on 3.11 which would be relevant here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #722 +/- ##
=======================================
Coverage 81.97% 81.97%
=======================================
Files 41 41
Lines 4149 4149
=======================================
Hits 3401 3401
Misses 748 748 ☔ View full report in Codecov by Sentry. |
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i -e 's,3\\.7,3.8,g' .github/workflows/codespell.yml .github/workflows/docker.yml .github/workflows/lint.yml .github/workflows/release.yml .github/workflows/test.yml .github/workflows/typing.yml",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
@jwodder -- do you have quick clue on why we get older setuptools installed so that we get on py 3.12 |
|
@yarikoptic This is the fault of pylibjpeg-libjpeg. Its build requirements pin setuptools for some reason, but the actual build failure is due to the fact that these requirements specify exactly numpy 1.23.2 on Python 3.11 and above, and that version (which was released over a year ago) requires distutils to install. |
|
Thank you @jwodder for the analysis!!! my humble attempt pydicom/pylibjpeg-libjpeg#48 |
|
meanwhile I will just drop attempt at 3.12 here, so we will just end up dropping 3.7 |
yarikoptic
changed the title
yarikoptic
added
patch
|
🚀 PR was released in |
